localadministrator/avbeat-com
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

ads: route all clicks through advertising.RMP.com/r/<id> + cache-aware banner reads

Browse Source 
Two compounding bugs caused 0 clicks since May 22:

1. lib/ads.ts exported ADS_728X90 / ADS_300X250 / FIXED_300X600 as
   IIFE-evaluated module constants. They captured the FALLBACK array
   at module-load time, before the centralized RMP banner cache
   populates. Every render that referenced them got FALLBACK banners
   whose click_url was the direct advertiser URL — bypassing the
   centralized click logger entirely. 300x250s escaped because every
   page reads them via rotateAll() at render time.

2. Even when the new RMP-cache banners did render, click_url pointed
   at www.RMP.com/<property>/<slug>, which logs to adv.banner_clicks.
   The RMP analytics dashboard reads bb.ad_clicks. Repointed click
   URLs at advertising.RMP.com/r/<campaign_id> so all clicks land in
   the single table the dashboard queries.

Files: lib/ads.ts (remove broken IIFE exports + repoint click_url),
SidebarAdStack, Header, Footer, and 9 pages (reading-list, forum,
forum/thread, search, gear, technology, authors, show-coverage x2).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
Ryan Salazar
2026-05-28 02:07:06 +00:00
parent 95eba5794b
commit ed764b1bbe
13 changed files with 52 additions and 45 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/app/authors/[slug]/page.tsx
View File

@@ -6,7 +6,7 @@ import AppImage from "@/components/ui/AppImage";
import Header from "@/components/Header";
import Footer from "@/components/Footer";
import AdImage from "@/components/AdImage";
import { ADS_728X90, shuffle } from "@/lib/ads";
import { pickAds } from "@/lib/ads";
import SidebarAdStack from "@/components/SidebarAdStack";
interface AuthorProfile {

6
src/app/forum/page.tsx
View File

@@ -5,7 +5,7 @@ import Header from '@/components/Header';
import Footer from '@/components/Footer';
import AdImage from '@/components/AdImage';
import SidebarAdStack from '@/components/SidebarAdStack';
import { ADS_728X90, shuffle } from '@/lib/ads';
import { pickAds } from '@/lib/ads';
import { createClient } from '@/lib/supabase/client';
interface ForumCategory {
@@ -632,9 +632,9 @@ export default function ForumIndexPage() {
</div>
{/* In-content 728x90 banner */}
{ADS_728X90.length > 0 && (
{pickAds("728x90", 1).length > 0 && (
<div className="mt-10 hidden md:flex justify-center" aria-label="Advertisement">
<AdImage ad={shuffle(ADS_728X90)[0]} page="forum" />
<AdImage ad={pickAds("728x90", 1)[0]} page="forum" />
</div>
)}

4
src/app/forum/thread/[id]/page.tsx
View File

@@ -5,7 +5,7 @@ import { useParams } from 'next/navigation';
import Header from '@/components/Header';
import Footer from '@/components/Footer';
import AdImage from '@/components/AdImage';
import { ADS_300X250, rotateAll } from '@/lib/ads';
import { pickAds, rotateAll } from '@/lib/ads';
import { createClient } from '@/lib/supabase/client';
import SidebarAdStack from "@/components/SidebarAdStack";
import LinkifyPlainText from "@/components/LinkifyPlainText";
@@ -13,7 +13,7 @@ import CompanyMentionsHover from "@/components/CompanyMentionsHover";
// Inline ad slot inserted between forum replies every N posts.
function InThreadAd({ adIndex }: { adIndex: number }) {
const pool = ADS_300X250;
const pool = rotateAll("300x250");
if (pool.length === 0) return null;
const ad = pool[adIndex % pool.length];
return (

6
src/app/gear/page.tsx
View File

@@ -5,7 +5,7 @@ import Header from "@/components/Header";
import Footer from "@/components/Footer";
import AppImage from "@/components/ui/AppImage";
import AdImage from "@/components/AdImage";
import { ADS_728X90, shuffle } from "@/lib/ads";
import { pickAds } from "@/lib/ads";
import { getLegacyArticlesBySection } from "@/lib/articles/legacy-source";
import SidebarAdStack from "@/components/SidebarAdStack";
@@ -91,9 +91,9 @@ export default async function GearPage() {
</div>
{/* In-content 728x90 banner */}
{ADS_728X90.length > 0 && (
{pickAds("728x90", 1).length > 0 && (
<div className="mt-12 hidden md:flex justify-center" aria-label="Advertisement">
<AdImage ad={shuffle(ADS_728X90)[0]} page="gear" />
<AdImage ad={pickAds("728x90", 1)[0]} page="gear" />
</div>
)}
</main>

6
src/app/reading-list/page.tsx
View File

@@ -5,7 +5,7 @@ import AppImage from "@/components/ui/AppImage";
import Header from "@/components/Header";
import Footer from "@/components/Footer";
import AdImage from "@/components/AdImage";
import { ADS_728X90, shuffle } from "@/lib/ads";
import { pickAds } from "@/lib/ads";
import { createClient } from "@/lib/supabase/client";
import SidebarAdStack from "@/components/SidebarAdStack";
@@ -315,9 +315,9 @@ export default function ReadingListPage() {
</div>
{/* In-content 728x90 banner */}
{ADS_728X90.length > 0 && (
{pickAds("728x90", 1).length > 0 && (
<div className="max-w-container mx-auto px-4 mt-10 mb-6 hidden md:flex justify-center" aria-label="Advertisement">
<AdImage ad={shuffle(ADS_728X90)[0]} page="reading-list" />
<AdImage ad={pickAds("728x90", 1)[0]} page="reading-list" />
</div>
)}
</main>

6
src/app/search/page.tsx
View File

@@ -4,7 +4,7 @@ import Header from "@/components/Header";
import Footer from "@/components/Footer";
import AppImage from "@/components/ui/AppImage";
import AdImage from "@/components/AdImage";
import { ADS_728X90, shuffle } from "@/lib/ads";
import { pickAds } from "@/lib/ads";
import { searchLegacyArticles } from "@/lib/articles/legacy-source";
import SidebarAdStack from "@/components/SidebarAdStack";
@@ -99,9 +99,9 @@ export default async function SearchPage({ searchParams }: SearchPageProps) {
</div>
{/* In-content 728x90 banner */}
{ADS_728X90.length > 0 && (
{pickAds("728x90", 1).length > 0 && (
<div className="mt-10 hidden md:flex justify-center" aria-label="Advertisement">
<AdImage ad={shuffle(ADS_728X90)[0]} page="search" />
<AdImage ad={pickAds("728x90", 1)[0]} page="search" />
</div>
)}
</main>

6
src/app/show-coverage/[slug]/page.tsx
View File

@@ -5,7 +5,7 @@ import Header from "@/components/Header";
import Footer from "@/components/Footer";
import AdImage from "@/components/AdImage";
import SidebarAdStack from "@/components/SidebarAdStack";
import { ADS_728X90, shuffle } from "@/lib/ads";
import { pickAds } from "@/lib/ads";
export const dynamic = "force-dynamic";
export const revalidate = 600;
@@ -215,9 +215,9 @@ export default async function EventCoveragePage({
</header>
{/* In-content 728x90 banner */}
{ADS_728X90.length > 0 && (
{pickAds("728x90", 1).length > 0 && (
<div className="my-8 hidden md:flex justify-center" aria-label="Advertisement">
<AdImage ad={shuffle(ADS_728X90)[0]} page="show-coverage" />
<AdImage ad={pickAds("728x90", 1)[0]} page="show-coverage" />
</div>
)}

6
src/app/show-coverage/page.tsx
View File

@@ -3,7 +3,7 @@ import { createClient } from "@supabase/supabase-js";
import Header from "@/components/Header";
import Footer from "@/components/Footer";
import AdImage from "@/components/AdImage";
import { ADS_728X90, shuffle } from "@/lib/ads";
import { pickAds } from "@/lib/ads";
import SidebarAdStack from "@/components/SidebarAdStack";
export const dynamic = "force-dynamic";
@@ -94,9 +94,9 @@ export default async function ShowCoverageIndex() {
</section>
{/* In-content 728x90 banner */}
{ADS_728X90.length > 0 && (
{pickAds("728x90", 1).length > 0 && (
<div className="my-10 hidden md:flex justify-center" aria-label="Advertisement">
<AdImage ad={shuffle(ADS_728X90)[0]} page="show-coverage" />
<AdImage ad={pickAds("728x90", 1)[0]} page="show-coverage" />
</div>
)}

6
src/app/technology/page.tsx
View File

@@ -5,7 +5,7 @@ import Header from "@/components/Header";
import Footer from "@/components/Footer";
import AppImage from "@/components/ui/AppImage";
import AdImage from "@/components/AdImage";
import { ADS_728X90, shuffle } from "@/lib/ads";
import { pickAds } from "@/lib/ads";
import { getLegacyArticlesBySection } from "@/lib/articles/legacy-source";
import SidebarAdStack from "@/components/SidebarAdStack";
@@ -213,9 +213,9 @@ export default async function TechnologyPage({ searchParams }: PageProps) {
</div>
{/* In-content 728x90 banner */}
{ADS_728X90.length > 0 && (
{pickAds("728x90", 1).length > 0 && (
<div className="mt-12 hidden md:flex justify-center" aria-label="Advertisement">
<AdImage ad={shuffle(ADS_728X90)[0]} page="technology" />
<AdImage ad={pickAds("728x90", 1)[0]} page="technology" />
</div>
)}
</main>